Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed <>& from the list of allowed symbols in password generation #2435

Merged
merged 2 commits into from Dec 6, 2018
Merged

fix: removed <>& from the list of allowed symbols in password generation #2435

merged 2 commits into from Dec 6, 2018

Conversation

garethjevans
Copy link
Member

@garethjevans garethjevans commented Dec 6, 2018 •
edited

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

fixes #

@garethjevans
Copy link
Member Author

Fixes #2406

@rawlingsj
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 5394a08 into jenkins-x:master Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccojocar ccojocar Awaiting requested review from ccojocar

@rajdavies rajdavies Awaiting requested review from rajdavies

Assignees

@rawlingsj rawlingsj

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garethjevans @rawlingsj @jenkins-x-bot