New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed <>& from the list of allowed symbols in password generation #2435

Merged
merged 2 commits into from Dec 6, 2018

Conversation

Projects
None yet
3 participants
@garethjevans
Copy link
Member

garethjevans commented Dec 6, 2018

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

fixes #

@jenkins-x-bot jenkins-x-bot requested review from ccojocar and rajdavies Dec 6, 2018

@jenkins-x-bot jenkins-x-bot added the size/S label Dec 6, 2018

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 6, 2018

Fixes #2406

@rawlingsj

This comment has been minimized.

Copy link
Member

rawlingsj commented Dec 6, 2018

/lgtm

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 5394a08 into jenkins-x:master Dec 6, 2018

1 of 2 checks passed

tide Not mergeable. Needs updatebot label.
Details
serverless-jenkins succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment