Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninstall wrong code location #2463

Merged
merged 3 commits into from Dec 10, 2018

Conversation

runzexia
Copy link

@runzexia runzexia commented Dec 9, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

@ccojocar

Which issue this PR fixes

fixes #

@jenkins-x-bot
Copy link
Contributor

Hi @runzexia. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runzexia
Copy link
Author

runzexia commented Dec 9, 2018

/assign @ccojocar

@garethjevans
Copy link
Member

/ok-to-test

@ccojocar
Copy link
Contributor

/test bdd

1 similar comment
@ccojocar
Copy link
Contributor

/test bdd

@ccojocar
Copy link
Contributor

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar
Copy link
Contributor

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 12d945a into jenkins-x:master Dec 10, 2018
@runzexia runzexia deleted the fix-uninstall branch December 11, 2018 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants