New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix uninstall wrong code location #2463

Merged
merged 3 commits into from Dec 10, 2018

Conversation

Projects
None yet
4 participants
@runzexia
Copy link
Contributor

runzexia commented Dec 9, 2018

Submitter checklist

  • Change is code complete and matches issue description.
  • Change is covered by existing or new tests.

Description

Special notes for the reviewer(s)

@ccojocar

Which issue this PR fixes

fixes #

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 9, 2018

Hi @runzexia. Thanks for your PR.

I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runzexia

This comment has been minimized.

Copy link
Contributor

runzexia commented Dec 9, 2018

/assign @ccojocar

@garethjevans

This comment has been minimized.

Copy link
Member

garethjevans commented Dec 9, 2018

/ok-to-test

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 10, 2018

/test bdd

1 similar comment
@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 10, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot removed the lgtm label Dec 10, 2018

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 10, 2018

/lgtm

@jenkins-x-bot jenkins-x-bot added the lgtm label Dec 10, 2018

@jenkins-x-bot

This comment has been minimized.

Copy link
Contributor

jenkins-x-bot commented Dec 10, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccojocar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ccojocar

This comment has been minimized.

Copy link
Member

ccojocar commented Dec 10, 2018

/test bdd

@jenkins-x-bot jenkins-x-bot merged commit 12d945a into jenkins-x:master Dec 10, 2018

2 checks passed

serverless-jenkins succeeded
tide In merge pool.
Details

@runzexia runzexia deleted the runzexia:fix-uninstall branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment