Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: making sure boot repo exists before loading requirements #6802

Merged
merged 1 commit into from Feb 25, 2020

Conversation

hferentschik
Copy link

fixes #6798

@abayer
Copy link
Contributor

abayer commented Feb 25, 2020

/retest

pkg/cmd/boot/boot.go Outdated Show resolved Hide resolved
pkg/cmd/boot/boot.go Outdated Show resolved Hide resolved
pkg/cmd/boot/boot.go Outdated Show resolved Hide resolved
pkg/cmd/boot/boot.go Outdated Show resolved Hide resolved
@hferentschik hferentschik changed the title [wip] fix: making sure boot repo exists before loading requirements fix: making sure boot repo exists before loading requirements Feb 25, 2020
@hferentschik hferentschik force-pushed the issue-6798 branch 2 times, most recently from b3e17c5 to 60f12e3 Compare February 25, 2020 16:25
@hferentschik
Copy link
Author

/test all

@hferentschik
Copy link
Author

/test all

1 similar comment
@hferentschik
Copy link
Author

/test all

@abayer
Copy link
Contributor

abayer commented Feb 25, 2020

/retest

@abayer
Copy link
Contributor

abayer commented Feb 25, 2020

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abayer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 9c7d783 into jenkins-x:master Feb 25, 2020
@jenkins-x-bot
Copy link
Contributor

@hferentschik: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
bdd 6fb6418 link /test bdd

View all Builds for this Pull Request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to execute 'jx boot' from outside a boot repo
4 participants