Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download instructions #8640

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: download instructions #8640

merged 1 commit into from
Dec 20, 2023

Conversation

msvticket
Copy link
Member

fixes #8517

fixes #8517

Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se>
@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85be6f2) 34.62% compared to head (1a23ae5) 34.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8640   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files          11       11           
  Lines        1242     1242           
=======================================
  Hits          430      430           
  Misses        767      767           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msvticket
Copy link
Member Author

/retest

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msvticket
Copy link
Member Author

/retest

@jenkins-x-bot jenkins-x-bot merged commit d9d3106 into main Dec 20, 2023
11 checks passed
@jenkins-x-bot jenkins-x-bot deleted the fix_download_instructions branch December 20, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download urls are broken for jx, missing v in version number part of the url
3 participants