Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing labels field #1481

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

msvticket
Copy link
Member

@msvticket msvticket commented Jan 23, 2024

It's a bit surprising that setting labels on ingresses via the helm charts of applications created from the packs has been broken until now. But so it is...

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket
Copy link
Member Author

/cc @tomhobson

@jenkins-x-bot
Copy link
Contributor

Valid linters:

  • tasks

@msvticket
Copy link
Member Author

/approve

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msvticket, tomhobson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [msvticket,tomhobson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot
Copy link
Contributor

Valid linters:

  • tasks

@jenkins-x-bot jenkins-x-bot merged commit 2fecce1 into jenkins-x:master Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants