fix: trigger jobs only when there is a GUID

Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>

pkg/plugins/trigger/pull-request.go

@@ -19,6 +19,7 @@ package trigger
 import (
 	"fmt"
 	"net/url"
+	"os"
 
 	"github.com/jenkins-x/go-scm/scm"
 	"github.com/jenkins-x/lighthouse/pkg/config/job"

pkg/plugins/trigger/pull-request_test.go

@@ -17,6 +17,7 @@ limitations under the License.
 package trigger
 
 import (
+	"os"
 	"testing"
 
 	"github.com/jenkins-x/go-scm/scm"
@@ -259,7 +260,7 @@ func TestHandlePullRequest(t *testing.T) {
 	}
 	for _, tc := range testcases {
 		t.Logf("running scenario %q", tc.name)
-
+		os.Setenv("GIT_KIND", "github")
 		g := &fake2.SCMClient{
 			PullRequestComments: map[int][]*scm.Comment{},
 			OrgMembers:          map[string][]string{"org": {"t"}},
@@ -317,6 +318,7 @@ func TestHandlePullRequest(t *testing.T) {
 					},
 				},
 			},
+			GUID: "test-guid",
 		}
 		if tc.prChanges {
 			pr.Changes = scm.PullRequestHookChanges{

pkg/plugins/trigger/trigger.go

@@ -278,6 +278,13 @@ func runRequested(c Client, pr *scm.PullRequest, requestedJobs []job.Presubmit,
 		return err
 	}
 
+	// If there is no eventguid from the scm provider, let's skip the build
+	// Also, for now, let's skip only github, not sure how other SCM providers handle GUID
+	if eventGUID == "" && os.Getenv("GIT_KIND") == "github" {
+		c.Logger.Infof("Skipping build as event GUID is missing for provider %s", os.Getenv("GIT_KIND"))
+		return fmt.Errorf("event GUID is empty")
+	}
+
 	var errors []error
 	for _, job := range requestedJobs {
 		c.Logger.Infof("Starting %s build.", job.Name)

pkg/triggerconfig/inrepo/load_integration_test.go

@@ -33,7 +33,6 @@ func TestMergeConfigIntegration(t *testing.T) {
 	flag, err := MergeTriggers(cfg, pluginCfg, fileBrowsers, fc, NewResolverCache(), repoOwner, repoName, sha)
 	require.NoError(t, err, "failed to merge configs")
 	assert.True(t, flag, "did not return merge flag")
-
 	// lets display the context
 	LogConfig(t, cfg)
 

pkg/triggerconfig/inrepo/load_triggers.go

@@ -29,6 +29,7 @@ func MergeTriggers(cfg *config.Config, pluginCfg *plugins.Configuration, fileBro
 	if err != nil {
 		return false, errors.Wrap(err, "failed to load configs")
 	}
+
 	if repoConfig == nil {
 		return false, nil
 	}