Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip check on repo length to support nested gitlab repos #1390

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

ankitm123
Copy link
Member

Signed-off-by: ankitm123 ankitmohapatra123@gmail.com

fixes #1389

@ankitm123 ankitm123 marked this pull request as draft November 27, 2021 01:53
@ankitm123 ankitm123 marked this pull request as ready for review November 27, 2021 16:01
@ankitm123
Copy link
Member Author

/lgtm

@jenkins-x-bot
Copy link
Contributor

@ankitm123: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@ankitm123
Copy link
Member Author

/cc @rawlingsj

@ankitm123
Copy link
Member Author

did lgtm to the wrong PR 😬

Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
@@ -14,6 +14,7 @@ approvers:
- rawlingsj
- warrenbailey
- wbrefvem
- ankitm123
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can help in reviewing/approving some open PRs!

@rawlingsj
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitm123, rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 5dce87a into jenkins-x:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support gitlab nested groups
3 participants