Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support poller require release success #1398

Merged
merged 14 commits into from
Jan 11, 2022

Conversation

dippynark
Copy link
Contributor

@dippynark dippynark commented Dec 15, 2021

Adds a flag to keeping polling releases until the commit status is successful. This can be useful if you always expect releases to succeed.

The main issue with this implementation is that a more recent poll might overwrite an already successful status if the jobs overlap, causing unnecessary/continuous polling (since the go-scm library only exposes the most recent status for a particular context) so the user needs to ensure the poll interval is long enough to reduce the chance of this happening (e.g. longer than the job timeout). I have created an issue and a WIP PR to allow go-scm to support fixing this issue (for GitHub at least): jenkins-x/go-scm#314

@jenkins-x-bot
Copy link
Contributor

Hi @dippynark. Thanks for your PR.

I'm waiting for a jenkins-x or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@dippynark dippynark changed the title Support require success feat: Support require success Dec 15, 2021
@dippynark dippynark changed the title feat: Support require success WIP: feat: Support require success Dec 15, 2021
@dippynark dippynark changed the title WIP: feat: Support require success feat: Support require success Dec 15, 2021
@dippynark dippynark changed the title feat: Support require success WIP: feat: Support require success Dec 15, 2021
@dippynark dippynark changed the title WIP: feat: Support require success feat: Support require success Dec 16, 2021
@dippynark dippynark changed the title feat: Support require success feat: Support require release success Dec 16, 2021
@dippynark dippynark changed the title feat: Support require release success feat: Support requiring release success Dec 16, 2021
@dippynark dippynark changed the title feat: Support requiring release success feat: Support poller requiring release success Dec 16, 2021
@dippynark dippynark changed the title feat: Support poller requiring release success feat: Support poller require release success Dec 17, 2021
@ankitm123
Copy link
Member

/ok-to-test

@rawlingsj
Copy link
Member

/lgtm

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawlingsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jenkins-x-bot jenkins-x-bot merged commit 1950f8f into jenkins-x:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants