Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trigger on deploy status and periodically #1563

Merged
merged 22 commits into from
Feb 25, 2024
Merged

Conversation

msvticket
Copy link
Member

No description provided.

@jenkins-x-bot
Copy link
Contributor

[jx-info] Hi, we've detected that the pipelines in this repository are using a syntax that will soon be deprecated.
We'll continue to update you through PRs as we progress. Please check #8589 for further information.

@msvticket msvticket changed the title WIP: feat: triggeer och deploy status and periodically WIP: feat: trigger on deploy status and periodically Jul 25, 2023
@msvticket msvticket force-pushed the newtriggers branch 7 times, most recently from aad8df3 to 1d759c6 Compare July 26, 2023 17:01
@msvticket msvticket force-pushed the newtriggers branch 6 times, most recently from 29ed582 to f98d820 Compare July 28, 2023 15:31
@msvticket
Copy link
Member Author

Tests require jenkins-x/go-scm#404 to be merged

@tomhobson
Copy link
Member

@msvticket how we getting on with this? Need an assist or anything?

@msvticket
Copy link
Member Author

@msvticket how we getting on with this? Need an assist or anything?

I still have some unit tests to implement. Some tests for periodics are implemented, but none for deployment. Also I haven't done any manual tests yet.

Some documentation would be generated automatically, but some more should be written I guess.

So you could work on tests and docs... But I'll get to it eventually.

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

4 similar comments
@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

@jenkins-x-bot
Copy link
Contributor

Failed to merge this PR due to:

failed merging [1563]: [Method Not Allowed]

@jenkins-x-bot jenkins-x-bot merged commit 6e58825 into main Feb 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants