chore: Upgrade bank-vaults #351
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once we have the AWS infra for testing, it would be helpful to test out these PRs. |
|
I'll keep this as draft until a I can upgrade vault-instance after jenkins-x-charts/vault-instance#15 is merged. |
|
Now, the question is how to test this properly... |
|
Related: jenkins-x/jx#8257 |
|
Ran the tests on a k3s cluster, and it worked. Ofc, it was a new cluster. not an existing cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main reason for the upgrade is to get a version of vault with good support for short lived service account tokens.
https://www.vaultproject.io/docs/auth/kubernetes#kubernetes-1-21