Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify cluster resource labels as variables #65

Closed
hferentschik opened this issue Apr 7, 2020 · 1 comment · Fixed by #69
Closed

Allow to specify cluster resource labels as variables #65

hferentschik opened this issue Apr 7, 2020 · 1 comment · Fixed by #69
Assignees
@hferentschik
Labels
area/terraform kind/feature released

Comments

@hferentschik
Copy link
Contributor

To allow to apply custom labels to the created cluster, it makes sense to allow specifying cluster resource labels as input variables to the main Terraform script.

They belong to the google_container_cluster resource and look like this:

        resource_labels  = {
            "env"       = "staging"
            "managedby" = "terraform"
        }
hferentschik added a commit to hferentschik/terraform-google-jx that referenced this issue Apr 7, 2020
@hferentschik
fix: adding resource_lables variable to allow creation of cluster labels
2ca755f 
fixes jenkins-x#65
@hferentschik hferentschik mentioned this issue Apr 7, 2020
Merged
hferentschik added a commit to hferentschik/terraform-google-jx that referenced this issue Apr 7, 2020
@hferentschik
fix: adding resource_lables variable to allow creation of cluster labels
25b3bbb 
- Replacing all occurences of K8s with Kubernetes
- Updating README

fixes jenkins-x#65
hferentschik added a commit to hferentschik/terraform-google-jx that referenced this issue Apr 7, 2020
@hferentschik
fix: adding resource_labels variable to allow creation of cluster labels
954fde9 
- Replacing all occurences of K8s with Kubernetes
- Updating README

fixes jenkins-x#65
hferentschik added a commit to hferentschik/terraform-google-jx that referenced this issue Apr 7, 2020
@hferentschik
fix: adding resource_labels variable to allow creation of cluster labels
8df25a6 
- Replacing all occurences of K8s with Kubernetes
- Updating README

fixes jenkins-x#65
hferentschik added a commit to hferentschik/terraform-google-jx that referenced this issue Apr 7, 2020
@hferentschik
fix: adding resource_labels variable to allow creation of cluster labels
36c848c 
- Replacing all occurences of K8s with Kubernetes
- Updating README

fixes jenkins-x#65
hferentschik added a commit to hferentschik/terraform-google-jx that referenced this issue Apr 7, 2020
@hferentschik
fix: adding resource_labels variable to allow creation of cluster labels
8985b88 
- Replacing all occurences of K8s with Kubernetes
- Updating README

fixes jenkins-x#65
@hferentschik hferentschik self-assigned this Apr 7, 2020
jenkins-x-bot pushed a commit that referenced this issue Apr 7, 2020
@hferentschik @jenkins-x-bot
fix: adding resource_labels variable to allow creation of cluster labels
de13bef 
- Replacing all occurences of K8s with Kubernetes
- Updating README

fixes #65
@hferentschik
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hferentschik hferentschik

Labels
area/terraform kind/feature released
Projects
None yet
Milestone
No milestone
2 participants
@hferentschik @deanesmith