New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop mixing prs across branches #73
Stop mixing prs across branches #73
Conversation
Hi @ryandawsonuk. Thanks for your PR. I'm waiting for a jenkins-x member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Will be testing this with https://github.com/ryandawsonuk/updatebottestforbranches |
Have now used that tester project to successfully do the following:
|
@ryandawsonuk I added fix to include base branch ref in PR title in order to distinguish between single PRs using different base branch configurations. |
Here is the screenshot of two single PRs in https://github.com/Activiti/Activiti/pulls for each branch: develop branch:7.0.x branch: |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstrachan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently having trouble with pipelines so can't merge right now. http://jenkins.jx.35.240.9.95.nip.io/job/Activiti/job/activiti-build/job/7.0.x/12/console resulted in https://github.com/Activiti/Activiti/pull/2556/files , which is a mixture of the 7.0.x and 7.1.x release trains - more specifically the 7.0.x train made a commit to overwrite a PR on the 7.1.x train
That PR is https://api.github.com/repos/Activiti/Activiti/pulls/2556 - from there we can see that the base branch has a ref (
develop
) and updatebot needs to check the base branch ref against its yaml file for that repo before performing the updateAlso happens to include changes for #69 as based on same fork