Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to diagnose configurations #169

Merged
merged 22 commits into from Nov 15, 2019
Merged

Add support to diagnose configurations #169

merged 22 commits into from Nov 15, 2019

Conversation

yJunS
Copy link
Member

@yJunS yJunS commented Sep 29, 2019

Fix #134

@yJunS yJunS added the feature label Sep 29, 2019
@yJunS yJunS changed the title WIP: Add support to doctor Add support to doctor Nov 4, 2019
@LinuxSuRen LinuxSuRen changed the title Add support to doctor Add support to diagnose configurations Nov 5, 2019
LinuxSuRen
LinuxSuRen reviewed Nov 5, 2019
View reviewed changes
app/cmd/doctor.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen reviewed Nov 5, 2019
View reviewed changes
app/cmd/doctor.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen requested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please return an error only when there is something that goes wrong.

1 New Code Smells

app/cmd/doctor.go Outdated Show resolved Hide resolved
app/cmd/doctor.go Outdated Show resolved Hide resolved
app/cmd/doctor.go Outdated Show resolved Hide resolved
app/cmd/doctor.go Outdated Show resolved Hide resolved
app/cmd/doctor.go Outdated Show resolved Hide resolved
app/cmd/doctor.go Outdated Show resolved Hide resolved
app/cmd/doctor.go Outdated Show resolved Hide resolved
client/pluginManager_test.go Outdated Show resolved Hide resolved
client/pluginManger.go Outdated Show resolved Hide resolved
client/pluginManger.go Outdated Show resolved Hide resolved
@LinuxSuRen LinuxSuRen added this to the v0.0.23 milestone Nov 5, 2019
LinuxSuRen
LinuxSuRen reviewed Nov 6, 2019
View reviewed changes
app/cmd/doctor.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen reviewed Nov 10, 2019
View reviewed changes
client/test_methods.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen reviewed Nov 10, 2019
View reviewed changes
client/test_methods.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen reviewed Nov 10, 2019
View reviewed changes
client/test_methods.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to go. We can improve some places later. For example, the handle of errors, create an interface allows us to register different checkpoints. And thanks for your contribution.

@LinuxSuRen LinuxSuRen merged commit b5a44c8 into jenkins-zh:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.0.23
Development

Successfully merging this pull request may close these issues.

Add support to check config items as a doctor
2 participants
@yJunS @LinuxSuRen