Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact download url construction #750

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix artifact download url construction #750

merged 1 commit into from
Feb 8, 2023

Conversation

sikmir
Copy link
Contributor

@sikmir sikmir commented Feb 4, 2023

Resolves #660

@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Base: 37.98% // Head: 37.98% // No change to project coverage 👍

Coverage data is based on head (cb4c34c) compared to base (c604484).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   37.98%   37.98%           
=======================================
  Files          13       13           
  Lines         416      416           
=======================================
  Hits          158      158           
  Misses        246      246           
  Partials       12       12           
Flag Coverage Δ
unittests 37.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LinuxSuRen
Copy link
Member

hi @sikmir , thanks for the fixing. I'll test this PR as soon as possible. Those e2e tests might be outdated. Please ignore them.

@LinuxSuRen LinuxSuRen merged commit f6e3b54 into jenkins-zh:master Feb 8, 2023
@sikmir sikmir deleted the fix-job-artifact-download branch February 8, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jcli job artifact download not working
2 participants