remove "tasklist" in pull_request_template.md and replace with stock checkboxes

[jtnord]

the ```[tasklist] caused the tasklist to be rendered as code in preview, and has often been broken this passed week.

checkboxes work, so just replace the tasklist with them.

e.g. use the preview on the existing file https://github.com/jenkinsci/.github/blob/ba0b88f732b4f48ed84c583524e2345427cd3f0c/.github/pull_request_template.md#testing-done

Testing done

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist Loading

[timja]

It doesn't though? i.e. check the description from this PR or e.g. jenkinsci/acceptance-test-harness#1563

[lemeurherve]

AFAIK the current syntax is the expected one for GitHub to render this block as a task list instead of a simple list.

The code block rendering is shown in the preview only, then rendered as a proper task list when submitted.

[jtnord]

THen GitHub is playing beta testing as I am constantly having to remove this from my PRs. e.g. see jenkinsci/google-compute-engine-plugin#465

[jtnord]

using the ```[tasklist] (ie just creating a PR in this repo)

[lemeurherve]

That's expected, GitHub doesn't render a proper task list on preview, only when posted.

[lemeurherve]

I encountered intermittent issues these last days when submitting PRs with task list returning an error message block instead, but editing the body and copy/pasting from a new template resolved it each time.

[jtnord]

That's expected, GitHub doesn't render a proper task list on preview, only when posted.

? it does it you remove the bits ``` ?

I encountered intermittent issues these last days when submitting PRs with task list returning an error message block instead, but editing the body and copy/pasting from a new template resolved it each time.

I also see regularly see that.

Right so my PR is then just a regular list of checkboxes not a "tasklist" but Tasklists is on life support and will be replaced with something else in the future.

given this is often broken recently and breaks preview does this extra actually bring any value?

[lemeurherve]

? it does it you remove the bits ``` ?

I don't modify nor remove the backticks when posting or editing.

Right so my thing is just a regular list of cehckboxes not a "tasklist" but Tasklists is on life support and will be replaced with something else in the future.

Thanks for the link and info!

EDIT:
Found the issue I encounter in this thread: https://github.com/orgs/community/discussions/39106#discussioncomment-9436673

given this is often broken recently and breaks preview does this extra actually bring any value?

I agree there is little to no value added with a task list compared to a normal list, they both are counted in listings.

The only diff is that there is a "done" count in the task list instead of just the total count.

VS

[jtnord]

that there is a "done" count in the task list instead of just the total count.

I have never noticed that until you just pointed it out now :)

but I just marked one as done and