Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kubernetes and file operations steps mocks #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahmoud-ashi
Copy link

Add mocks for steps from https://github.com/jenkinsci/kubernetes-plugin
Add mocks for steps from https://github.com/jenkinsci/file-operations-plugin
Add mock for libraryResource, lock, powershell
Fix mock for unstash step
Fix recently added mock for timeout with integer argument

Add mocks for steps from https://github.com/jenkinsci/kubernetes-plugin
Add mocks for steps from https://github.com/jenkinsci/file-operations-plugin
Add mock for `libraryResource`, `lock`, `powershell`
Fix recently added mock for `timeout` with integer argument
Copy link
Contributor

@nre-ableton nre-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split 963ce57 up into 5 commits:

  • One for the libraryResource mock
  • One for the lock mock
  • One for the powershell mock
  • One for the timeout fix
  • One for the unstash fix (which should probably include a corresponding fix for stash, since these steps are related).

That will make this PR much easier to review.

As for the mocks for Kubernetes and file-operations-plugins, please also split those into separate commits and make new PRs for each of them. I am personally disinclined to include mocks for such plugins in this library, since I believe that it should only cover base pipeline steps (otherwise, there is no limit to how much this library will grow, and it will get more difficult to maintain). However, I may be convinced otherwise, but we should have these discussions with other maintainers/contributors in a separate PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants