Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use a single type in MockScriptHandler constructor #541

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Don't use a single type in MockScriptHandler constructor #541

merged 2 commits into from
Jul 11, 2022

Commits on Jul 5, 2022

  1. Add tests for addShMock(regex, stdout, status)

    @nre-ableton
    nre-ableton committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    863d21b View commit details
    Browse the repository at this point in the history

  2. Don't use a single type in MockScriptHandler() 

    The previous implementation of the MockScriptHandler constructor was a
bit brittle and confusing. The first parameter was an Object which could
either be null (for no pattern matching), a String (for full pattern
matching), or a Pattern (for a regexp pattern match).

This change now provides three different constructors for the three
different use-cases detailed above, and also creates separate fields for
the various matches. This means we no longer need to rely on instanceof
to see what type of filter should be applied.
    @nre-ableton
    nre-ableton committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    dd16e4a View commit details
    Browse the repository at this point in the history