Skip to content

Commit

Permalink
Temp v2 version check with TODO for post 2.0 release
Browse files Browse the repository at this point in the history
 The fact that it's a beta release means it is older than version "2" for the VersionNumber class.
  • Loading branch information
tfennelly committed Apr 1, 2016
1 parent 4f06d0a commit c22403d
Showing 1 changed file with 4 additions and 1 deletion.
Expand Up @@ -95,7 +95,10 @@ public ToolInstallation(Jenkins jenkins, String path) {
}

protected static ConfigurablePageObject getPageObject(Jenkins jenkins) {
return jenkins.getVersion().isOlderThan(new VersionNumber("2"))
// TODO: change to jenkins.getVersion().isOlderThan(new VersionNumber("2")) after 2.0 is released.
// yeah, you could do a number of things here e.g. isNewerThan("1.1000") etc,
// but this is fine as it's temporary.
return jenkins.getVersion().toString().startsWith("1.")
? new JenkinsConfig(jenkins)
: new GlobalToolConfig(jenkins);
}
Expand Down

0 comments on commit c22403d

Please sign in to comment.