Forward compatibility for refresh update sites button change #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plugins.WorkflowPluginTest.sshGitInsideDocker is the only test failing now, reckon that's related to the change? @timja |
Unsure, but it is failing in plugin manager code so better safe than sorry. I've reran it in case there was an upstream failure |
NotMyFault
approved these changes
Mar 28, 2023
timja
reviewed
Mar 28, 2023
| @@ -88,7 +88,7 @@ public void checkForUpdates() { | |||
| // The check now button is a form submit (POST) with a redirect to the same page only if the check is successful. | |||
| // We use the button itself to detect when the page has changed, which happens after the refresh has been done | |||
| // And we check for the presence of the button again | |||
| WebElement checkButton = find(by.link("Check now")); | |||
| WebElement checkButton = find(by.css("form[action='checkUpdatesServer'] .jenkins-button")); | |||
There was a problem hiding this comment.
The button prior to this PR didn't have an ID
timja
changed the title
timja
approved these changes
Mar 28, 2023
I had assumed the old button would have been wrapped in a form, instead it does some JS magic to do the post instead.
|
The test is failing in the plugin manager so likely needs adjusting |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing jenkinsci/jenkins#7770