[WIP] [JENKINS-38307] Stop installing detached plugins #191
Conversation
|
Noting that this will likely break a lot of tests, but since I'd rather not cause a brown out by running the ATH locally, I'll let the PR builder handle it. |
|
@recampbell If we do that, what happens whether we want to run the ATH with previous releases of 2.x? /cc @olivergondza |
|
@recena, Good point, that needs to be retested. The change itself did not break much actually. |
…cent versions of plugins, not whatever old stuff happened to be in the detached list.
|
The fact we do this seems to be cause of plugin installations problems or an extra work at least. We unbundle outdated credentials plugin, and dynamic deploy of needed plugins fails because credentials plugins is too old. If we quit doing that, the correct plugin version can be installed right away. My initial concern about pre-2.0 jenkins is not valid as we have started to do this after 2.0 - the older version will unbundle the plugins correctly. I am running tests against 1.609.3 and 2.19.3 before I merge this. |
[WIP] [JENKINS-38307] Stop installing detached plugins
|
There seems to be ~5 ATH testcases affected by JENKINS-37545. Since the bug is and will be present in releases we want to support in ATH for a while and plugin installation is sort of crucial. I lean towards updating the testcases so the detached dependencies are requested explicitly. It will cause no harm to Jenkins 1.X and will make Jenkins 2.X work. |
|
Continuing in #251. |
We should just let the war behave as normal instead of hacking the plugins to avoid fixing some WithPlugin lists.