Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-28550] Test reviewed to work fine with the new proposal of side-panel and main-panel #27

Merged
merged 1 commit into from Jul 5, 2015

Conversation

recena
Copy link
Contributor

@recena recena commented Jul 5, 2015

This PR have modified DOM tree in the main layout. These changes affect to side-panel and main-panel. From now on, div#main-panel-content won't exist.

@recena recena changed the title [JENKINS-28550] Test reviewed [JENKINS-28550] Test reviewed to work fine with the new proposal of side-panel and main-panel Jul 5, 2015
@daniel-beck
Copy link
Member

@olivergondza Any possible problems with this change merged the same time as jenkinsci/jenkins#1717, e.g. Jenkins LTS ATH runs?

@olivergondza
Copy link
Member

If I am not mistaken, it will work with both new and old version after this fix. In that case, 👍 .

@recena
Copy link
Contributor Author

recena commented Jul 5, 2015

@olivergondza Thanks so much for your quick feedback

daniel-beck added a commit that referenced this pull request Jul 5, 2015
[JENKINS-28550] Test reviewed to work fine with the new proposal of side-panel and main-panel
@daniel-beck daniel-beck merged commit f824957 into jenkinsci:master Jul 5, 2015
@daniel-beck
Copy link
Member

@olivergondza Great, thanks!

olivergondza pushed a commit that referenced this pull request Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants