Update README to reflect where we want ATH to be #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
reviewed
Oct 6, 2017
README.md
Outdated
| master | stable | ||
| ------ | ------ | ||
| [](https://jenkins.ci.cloudbees.com/job/core/job/acceptance-test-harness/) | [](https://jenkins.ci.cloudbees.com/job/core/job/acceptance-test-harness-stable/) | ||
| The scenarios are described as unit tests controlling Jenkins through UI / REST API. Clean instance is started for |
There was a problem hiding this comment.
They are not “unit” tests, just tests using the JUnit framework.
| There is a bit of a delay since we bring up Jenkins for every single test, with | ||
| it's own sandboxed workspace. | ||
| The simplest way to start the harness is calling `BROWSER=firefox JENKINS_VERSION=latest mvn test`. Complete test suite | ||
| takes hours to run due to the number of covered components/use-cases, the cost of Jenkins setup and selenium interactions. |
There was a problem hiding this comment.
So offer a tip here on selecting smoke tests.
README.md
Outdated
| * [Managing the versions of Jenkins and plugins](docs/SUT-VERSIONS.md) | ||
| * [Using a http proxy](docs/USING-A-HTTP-PROXY.md) | ||
| * [Prelaunchint JUT](docs/PRELAUNCH.md) |
There was a problem hiding this comment.
(and people will not know what “JUT” means; explained in the next item but that should be moved up)
README.md
Outdated
| * [Running tests in container](docs/DOCKER.md) | ||
| * Selecting tests based on plugins they cover (TODO) | ||
|
|
||
| ### Writing tests | ||
|
|
||
| Given how log does it take for the suite to run, test authors are advised to focus on the most popular plugins and |
There was a problem hiding this comment.
s/log does it take/long it takes/
README.md
Outdated
| * [Running tests in container](docs/DOCKER.md) | ||
| * Selecting tests based on plugins they cover (TODO) | ||
|
|
||
| ### Writing tests | ||
|
|
||
| Given how log does it take for the suite to run, test authors are advised to focus on the most popular plugins and | ||
| use-cases to maximize the value of the test suite. Tests that can or already are written as a part of core/plugin tests |
There was a problem hiding this comment.
Probably a good place to discuss what is and is not practical to do with JenkinsRule and thus what the reasons would be for writing something using ATH.
|
Thanks for the review, Jesse. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting our new policy for test types we want ATH to hold as well as broken/flaky test eviction policy.
See https://groups.google.com/forum/#!topic/jenkinsci-dev/R8w7uhh-xbgfor discussion.
CC @jenkinsci/code-reviewers