Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for cifs publisher #436

Merged
merged 5 commits into from Jun 11, 2018

Conversation

olivergondza
Copy link
Member

No description provided.

@lvotypko
Copy link
Member

lvotypko commented Jun 6, 2018

I agree, due to problems with docker cp, see [1], it is better not to use it if it is not necessary. In this case it can be easy done another way.

[1] jenkinsci/docker-fixtures#17

@olivergondza
Copy link
Member Author

This is still a work in progress as this has uncovered what appears to be a real regression in the plugin.

@olivergondza olivergondza changed the title Avoid copying files for something this trivial Fix tests for cifs publisher Jun 8, 2018
@olivergondza
Copy link
Member Author

Filing the discovered issue as https://issues.jenkins-ci.org/browse/JENKINS-51852

@olivergondza olivergondza merged commit 04937e5 into jenkinsci:master Jun 11, 2018
@oleg-nenashev
Copy link
Member

There is also https://issues.jenkins-ci.org/browse/JENKINS-51853 which looks quite troublesome

@olivergondza
Copy link
Member Author

Their plugin version is fairly old...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants