Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance tests for Warnings Next Generation Plugin #479

Closed
wants to merge 118 commits into from
Closed

Acceptance tests for Warnings Next Generation Plugin #479

wants to merge 118 commits into from

Conversation

uhafner
Copy link
Member

@uhafner uhafner commented Feb 13, 2019 •
edited

Provides several tests for the Warnings Next Generation Plugin.

  • Add page objects for most important plugin views
  • Add tests for most important use cases
  • Refactor page objects to make them more readable and use the same style
  • Verify tests on Linux and Chromium
  • Verify tests on maxOs and Chrome
  • Verify tests on Linux and Firefox
  • Verify tests on macOS and Firefox

uhafner and others added 30 commits May 22, 2018 10:09
@uhafner
Added some scripts to simplify startup
8df74f8
@uhafner
Added coding style to project.
1ace246
@uhafner
Added coding style.
17fedd4
@uhafner
Added UI test example for the warnings-plugin.
9bcf93a
@Arne2
add inputs for ReferenceFinder
d574675
@uhafner
Merge pull request #5 from Arne2/hm-edu-testing
b55775f 
Add inputs for ReferenceFinder
@uhafner
Do not check method names since they may contain underscores.
735469e
@uhafner
Use Select helper class to choose selected option of <select/>.
4b9e221
simple test for duplicate code warnings
12173e2
@DarphBobo
Zwischenstand (sync to notebook)
e37363a
@DarphBobo
zwischenstand
35dd09b
@DarphBobo
Zwischenstand (sync to notebook)
d442716
@A-MSG
Added two UI-Tests for Aggregation is false and true.
a366b20
@DarphBobo
Zwischenstand (sync to notebook)
41ec58c
@DarphBobo
Merge pull request #1 from DarphBobo/issue_regex_filter
5440ebb 
Issue regex filter
@mmxkcd
qualitygate acceptance test implementation
1d6291d
@DarphBobo
WIP
3cb1fe6
@DarphBobo
Added ressources to git ;-)
3b61601
Getting result details page
a47470f
@uhafner
Small refactorings.
c1854b9
@uhafner
Merge branch 'TestUIAggregation' of https://github.com/A-MSG/acceptan…
581e834 
…ce-test-harness into A-MSG-TestUIAggregation

# Conflicts:
#	src/test/java/plugins/AnalysisPluginsTest.java
@uhafner
Merge branch 'TestUIAggregation' of https://github.com/A-MSG/acceptan…
f6107b0 
…ce-test-harness into A-MSG-TestUIAggregation

# Conflicts:
#	src/test/java/plugins/AnalysisPluginsTest.java
@uhafner
Merge branch 'A-MSG-TestUIAggregation' into hm-edu-testing
fb889c0 
# Conflicts:
#	src/test/java/plugins/AnalysisPluginsTest.java
@uhafner
Merge branch 'A-MSG-TestUIAggregation' into hm-edu-testing
76491fb 
# Conflicts:
#	src/test/java/plugins/AnalysisPluginsTest.java
@uhafner
Merge branch 'hm-edu-testing' of https://github.com/DarphBobo/accepta…
052166c 
…nce-test-harness into DarphBobo-hm-edu-testing

# Conflicts:
#	src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/IssuesRecorder.java
@uhafner
Merge branch 'hm-edu-testing' of https://github.com/DarphBobo/accepta…
379ec7f 
…nce-test-harness into DarphBobo-hm-edu-testing

# Conflicts:
#	src/main/java/org/jenkinsci/test/acceptance/plugins/warnings/IssuesRecorder.java
@AlexanderPraegla
Added test file to resources for message box
69eca5a
@AlexanderPraegla
Tried coping file to workspace in windows
940d918
@Arne2
fix copy for windows
76c2e09
@Arne2
clean up
f3adcff
@uhafner
Set sourceCodeEncoding to make tests independent of default encoding.
50a9ff3
@uhafner
Added missing openAdvancedButton calls.
5dcbc28
@uhafner
Update of test due to changed log message in 3.0.3.
820a442
@uhafner
Hide scroller when creating pipeline as well.
0ab2a75
@uhafner
Split info view test into 2 tests (freestyle vs. pipeline).
679452d
@uhafner
Simplified JS call.
35b08b2
@uhafner
Use JS to set the script content of the workflow editor (ACE editor).
4aef898
@uhafner
Reverted setting of the script in the ace editor using JS in token test.
e2b8c6a
@uhafner
Added a timeout for ace editor before setting the script.
c29fe43
@uhafner
Increase timeout to 10 sec.
f58801c
@uhafner
Added dependency to workflow plugins.
e02e6b6
@uhafner
Removed ace editor script enhancements.
50a5313
@uhafner
Restored accidentally removed method 'setJenkinsFileRepository'.
fbb304d
@uhafner
Fixed whitespace changes in WorkflowJob.
bb55f6e
@uhafner uhafner changed the title [WIP] Acceptance tests for Warnings Next Generation Plugin Acceptance tests for Warnings Next Generation Plugin Feb 21, 2019
@uhafner
Copy link
Member Author

uhafner commented Feb 21, 2019

@olivergondza I finally managed it to get all tests running 🥇 On the configuration page I needed to remove the div with our famous navigation bar.

@uhafner
Copy link
Member Author

uhafner commented Mar 8, 2019

@olivergondza ping. Anything else I should do?

olivergondza
olivergondza reviewed Mar 11, 2019
View reviewed changes
src/test/resources/warnings_plugin/checkstyle-result.xml Outdated
@@ -0,0 +1,35 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file appears unused

@olivergondza
Copy link
Member

I am glad to hear that! @uhafner, what is your vision about assertj's usage in ATH? I am still a bit uneasy to use both hamcrest and assertj (putting aside plain old junit's Assert and various should methods), but it looks interesting in my opinion.

@uhafner
Copy link
Member Author

uhafner commented Mar 11, 2019

Did you see https://github.com/jenkinsci/acceptance-test-harness/pull/479/files#r256992566?

I don't want to force something new here. I think AssertJ style is better than the other styles but I don't think it is worth the effort to replace existing code. So if you feel uncomfortable with both styles then I can remove it. Since we anyway have the idea to move most of the tests to the plugin itself and just leave one or two inside the ATH I can remove it from the ATH sub set of tests and leave it in the warnings-ng part of the tests.

Is this approach of moving tests to a plugin working already? You referenced a PR some time ago but I don't find it anymore...

olivergondza added a commit to olivergondza/acceptance-test-harness that referenced this pull request Mar 11, 2019
@olivergondza
Merge pull request jenkinsci#479 from uhafner/warnings-ng
7901e26 
Acceptance tests for Warnings Next Generation Plugin
@olivergondza
Copy link
Member

I played with the assertj a bit and it seems to deliver better coding assistance and readability without impacting defect localization when compared to the alternatives. Let's keep it as it is so we will learn how well it does in the long term.

While at it, it found out the tests was failing for me locally because of Element <select class="setting-input dropdownList"> is not clickable at point (714,6) because another element <ul id="breadcrumbs"> obscures it. There appears to be an interesting corner case explained in the commit 39cbea4. BTW, the new warnings reports looks awesome!

The ATH extracting: I was able to achieve that but mind the TODO: https://github.com/jenkinsci/kerberos-sso-plugin/pull/14/files#diff-58231b16fdee45a03a4ee3cf94a9f2c3R14. The latest container is used no matter what ATH version you declare in pom with is going to be more and more of a problem with time.

@uhafner
Copy link
Member Author

uhafner commented Mar 20, 2019

Has been merged already.

@uhafner uhafner closed this Mar 20, 2019
@uhafner uhafner deleted the warnings-ng branch March 20, 2019 10:37
olivergondza added a commit that referenced this pull request Mar 20, 2019
@olivergondza
Merge pull request #479 from uhafner/warnings-ng
b47dcb9 
Acceptance tests for Warnings Next Generation Plugin
@olivergondza
Copy link
Member

Thanks @uhafner, merged!

jsoref pushed a commit to jsoref/acceptance-test-harness that referenced this pull request Mar 20, 2019
@olivergondza
Merge pull request jenkinsci#479 from uhafner/warnings-ng
3152aec 
Acceptance tests for Warnings Next Generation Plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivergondza olivergondza olivergondza left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@uhafner @olivergondza @Arne2 @DarphBobo @A-MSG @mmxkcd @AlexanderPraegla @watch-me-xplode @frankchrisg