Set firefox options consistently (local, container, remote) #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Vlatombe
commented
Sep 13, 2021
•
Vlatombe
commented
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did
- Link to relevant issues in GitHub or Jira
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
timja
approved these changes
Sep 13, 2021
Vlatombe
added a commit
to Vlatombe/acceptance-test-harness
that referenced
this pull request
Sep 23, 2021
Follows up on jenkinsci#680 and jenkinsci#684
6 tasks
jtnord
added a commit
to jtnord/acceptance-test-harness
that referenced
this pull request
Oct 11, 2021
jenkinsci#684 specified the firefox options consitently across all firefox browser types, however this broke remote-webdriver-firefox as the proxy was not localhost as far as firefox was conserned (as it was by definition remote). This cange makes the NIC to use for the proxy configurable so that you can bind to a specific NIC and pass that to firefox via selenium.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.