Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ubuntu 22.04 #878

Merged
merged 11 commits into from
Jan 31, 2023
Merged

Conversation

NotMyFault
Copy link
Member

@NotMyFault NotMyFault commented Aug 2, 2022

Closes #803

@NotMyFault NotMyFault force-pushed the ci/master/ubuntu-test branch 5 times, most recently from 2c7df41 to dfe6b81 Compare August 2, 2022 13:09
@timja
Copy link
Member

timja commented Aug 8, 2022

Seems to be running relatively good, although some scrolling issues.

I tried to run it on my machine but unfortunately mozilla has decided not to publish official arm64 binaries -.-
mozilla/geckodriver#1956

I'll try hack it later on so I can see if I can reproduce the issue

@NotMyFault
Copy link
Member Author

I tried to run it on my machine but unfortunately mozilla has decided not to publish official arm64 binaries -.-

Indeed, unfortunate, maybe we should give our gecko version an update while we're at it? It's almost 3 years old

@timja
Copy link
Member

timja commented Aug 9, 2022

Hacked on it for an hour and it still doesn't run on my machine -.-

But finally got geckodriver to start at least.

@timja timja changed the title Test on ubuntu 20.04 Test on ubuntu 22.04 Aug 10, 2022
@timja
Copy link
Member

timja commented Aug 10, 2022

Hacked on it for an hour and it still doesn't run on my machine -.-

Turns out it ran find I just had a partially downloaded war 🙄.

I can reproduce the CI issues locally at least. haven't had time to dig into them but cleaned up the Dockerfile changes and pushed in 9d06b05

@NotMyFault NotMyFault changed the title Test on ubuntu 22.04 Switch to ubuntu 22.04 Aug 11, 2022
@NotMyFault
Copy link
Member Author

Merging in master with the git client fixes reduced test failures a lot 👀

@NotMyFault NotMyFault marked this pull request as ready for review September 28, 2022 08:06
@NotMyFault
Copy link
Member Author

NotMyFault commented Sep 28, 2022

One test failure occurs in ConfigFileProviderTest#testCustomConfigFile() https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/PR-878/14/testReport/junit/plugins/ConfigFileProviderTest/java_11_jenkins_lts_split9___testCustomConfigFile/

I suspect this is a real failure this time, because it doesn't occur on the comparison build for the master branch, I used for a different PR: #956
Although I'm not sure why switching to Ubuntu would make this specific test fail...

Additionally, I disabled the pipeline for builds on infra.ci, because of several hadolint violations.

Jenkinsfile.infra.ci.jenkins.io Outdated Show resolved Hide resolved
@timja timja mentioned this pull request Oct 15, 2022
6 tasks
@NotMyFault NotMyFault merged commit c54ef5f into jenkinsci:master Jan 31, 2023
@NotMyFault NotMyFault deleted the ci/master/ubuntu-test branch January 31, 2023 19:20
@jtnord
Copy link
Member

jtnord commented Feb 21, 2023

Since this change any test that uses docker appears to be skipped as docker is no longer available.

see https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/master/684/testReport/plugins/WorkflowPluginTest/history/ compare 671 with 672

a couple of tests that require docker seem to also have regressed.

@raul-arabaolaza
Copy link
Contributor

As we are impacted by this in our proprietary suites, I am already checking what James said. I can confirm some tests have been ignored for months, apparently because docker is not installed. And they are failing in our env because we use another images with docker available.

I will update here and try to send a fix asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants