Don't skip doclint #891
Closed
Don't skip doclint #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
force-pushed
the
build/master/doclint
branch
from
165ca57
to
e554b96
Compare
(cherry picked from commit b5c1c0e)
timja
approved these changes
Aug 12, 2022
jtnord
reviewed
Aug 13, 2022
| @@ -485,6 +486,8 @@ | |||
| <artifactId>maven-source-plugin</artifactId> | |||
| <executions> | |||
| <execution> | |||
| <phase>compile</phase> | |||
There was a problem hiding this comment.
Why compile, this will be run on everysplit ATH.
Similar comment to below and the javadoc
Merged
|
Is this needed after #893? |
Given, the new task runs separately to the maven workflow to verify results independently, possibly not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build as-is fails for me locally if I invoke
mvn clean verify -DskipTests, and should fail on ci.j too, because we're lacking #890.