Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable cd #8

Merged
merged 1 commit into from Mar 12, 2024
Merged

ci: enable cd #8

merged 1 commit into from Mar 12, 2024

Conversation

viceice
Copy link
Member

@viceice viceice commented Mar 12, 2024

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@jglick
Copy link
Member

jglick commented Mar 12, 2024

I think in #5 you forgot to add the required files to .mvn/. Recheck https://www.jenkins.io/doc/developer/publishing/releasing-cd/#incrementals-enablement

@viceice
Copy link
Member Author

viceice commented Mar 12, 2024

I think in #5 you forgot to add the required files to .mvn/. Recheck https://www.jenkins.io/doc/developer/publishing/releasing-cd/#incrementals-enablement

Added in #7 🙃

@viceice viceice added the chore A PR that adds to maintenance - used by Release Drafter label Mar 12, 2024
@viceice viceice merged commit 3921414 into main Mar 12, 2024
@viceice viceice deleted the ci/enable-cd branch March 12, 2024 11:52
@jglick
Copy link
Member

jglick commented Mar 12, 2024

OK…though changelist.format is specific to CD, so this was a bit mixed up.

@viceice
Copy link
Member Author

viceice commented Mar 14, 2024

Ok. didn't know. I'm new to this kind of jenkins automation 🙃 Will try to remember when adopting other plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A PR that adds to maintenance - used by Release Drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants