Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-63580] Update regex for msbuild to recognize linker warnings #952

Merged
merged 2 commits into from Oct 4, 2023
Merged

[JENKINS-63580] Update regex for msbuild to recognize linker warnings #952

merged 2 commits into from Oct 4, 2023

Conversation

pyatizbyantsevia
Copy link
Contributor

@pyatizbyantsevia pyatizbyantsevia commented Oct 3, 2023

Closes JENKINS-63580

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the regular expression actually is degenerated, too many options have been added year by year. I tried to fix that a little bit, and now your test works :-)

(Maybe it makes sense to start from scratch sometimes... But for now the PR is ready to be integrated, thanks!)

@@ -1,4 +1,4 @@
<!--- DO NOT EDIT -- Generated at 2023-09-20T10:55:02.107301 - Run the `main` method of `ParserRegistry` to regenerate after changing parsers -- DO NOT EDIT --->
<!--- DO NOT EDIT -- Generated at 2023-10-03T10:06:45.445947 - Run the `main` method of `ParserRegistry` to regenerate after changing parsers -- DO NOT EDIT --->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove that file from the change list?

@uhafner uhafner added the bug Bugs or performance problems label Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #952 (df7c0ea) into master (590a415) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #952      +/-   ##
============================================
+ Coverage     92.94%   93.07%   +0.13%     
- Complexity     2368     2371       +3     
============================================
  Files           347      347              
  Lines          6592     6588       -4     
  Branches        686      686              
============================================
+ Hits           6127     6132       +5     
+ Misses          263      256       -7     
+ Partials        202      200       -2     
Files Coverage Δ
...a/edu/hm/hafner/analysis/parser/MsBuildParser.java 96.22% <100.00%> (+15.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pyatizbyantsevia pyatizbyantsevia marked this pull request as ready for review October 4, 2023 12:04
@pyatizbyantsevia
Copy link
Contributor Author

pyatizbyantsevia commented Oct 4, 2023

Thank you very much for making changes to my test, I focused on the parsing problem (on the first assert) and did not bring the test itself to the proper form.
P.s. Before accepting PR, I kindly ask you to put a label (probably HACKTOBERFEST-ACCEPTED) for Hacktoberfest =)

Upd: okay, as I see on the hactoberfest page, this PR has already been accepted and is being processed 😅

@uhafner uhafner added the hacktoberfest Pull requests that participate in Hacktoberfest label Oct 4, 2023
@uhafner uhafner merged commit 42177ba into jenkinsci:master Oct 4, 2023
27 checks passed
@uhafner
Copy link
Member

uhafner commented Oct 4, 2023

Ok, thanks, released in https://github.com/jenkinsci/analysis-model/releases/tag/v11.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems hacktoberfest Pull requests that participate in Hacktoberfest
Projects
None yet
2 participants