Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for mixture of Kotlin and CMake output #991

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

DennisBauer
Copy link
Contributor

For projects with a mixture of Kotlin and CMake compiles the output of both can be mixed depending on the order of the tasks. The working path defined by the CMake output should not be used for warnings which already print out absolute paths e.g. Kotlin warnings. It should only be used if the path is a relative path.

Testing done

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (93172ec) 93.09% compared to head (5aab948) 93.08%.
Report is 5 commits behind head on main.

Files Patch % Lines
...main/java/edu/hm/hafner/analysis/IssueBuilder.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #991      +/-   ##
============================================
- Coverage     93.09%   93.08%   -0.01%     
- Complexity     2382     2386       +4     
============================================
  Files           347      347              
  Lines          6603     6612       +9     
  Branches        687      689       +2     
============================================
+ Hits           6147     6155       +8     
- Misses          256      257       +1     
  Partials        200      200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request! Just a small simplification would be helpful.

src/main/java/edu/hm/hafner/analysis/IssueBuilder.java Outdated Show resolved Hide resolved
@uhafner uhafner added the bug Bugs or performance problems label Dec 21, 2023
@DennisBauer DennisBauer force-pushed the fix_kotlin_and_cmake_parsing branch 4 times, most recently from 2259f63 to 54accae Compare December 22, 2023 09:42
@DennisBauer
Copy link
Contributor Author

To make sure this works for building on all platforms, I also added a Windows path to the log and did some adjustments for it to work as well.

Copy link
Member

@uhafner uhafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good now! Only the tests could use better assertions for the file names.

@uhafner uhafner merged commit 83adbf0 into jenkinsci:main Jan 2, 2024
26 of 28 checks passed
@DennisBauer DennisBauer deleted the fix_kotlin_and_cmake_parsing branch February 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs or performance problems
Projects
None yet
2 participants