[JENKINS-64388] Update endpoints after AppCenter changes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was able to test this on our instance today. I attempted to upload both an APK using the GUI (using the legacy "Freestyle" job) and an IPA using the newer declarative pipeline syntax. The former gave this result, then hung forever: The latter gave this result and finally succeeded However both runs have this warning which looks like it's handling secrets wrong. |
|
Hi @NotTheEconomist thanks for testing it out. I'm a bit worried about that stacktrace since I don't think I changed anything relating to secrets in this PR. I've checked the type of Regarding the two log traces that eventually hang: Can you tell me what version of Jenkins you are using, the size of those files, and if possible past the pipeline configuration from your Jenkinsfile (obviously redacted as need). p.s. ❤️ the github handle 😺 |
|
@NotTheEconomist I suspect this is probably your issue about the Secrets JENKINS-62305. |
This is not needed after the API changes of 8 Dec 2020.
So that this changeset passing on the CI server.
|
If anyone is watching this with anticipation and are able to try this pre-release can you install the HPI from build 4 please. If you could let me know if that works for you I'd appreciate that. I've made some changes to how the chunked upload handled large files. |
|
Regarding the secrets handling stack trace above. I am more and more convinced this is a completely separate issue. I have raised a tracking defect as JENKINS-64495. I'll track issues there. For now I will continue on with addressing the changes in AppCenter endpoints here. |
Works for me. However, my files were only 2.7 and 3.8 MB in size. |
|
Thanks @jensneubauer ! |
worked for 97.18 MB apk |
|
Thanks @kgluszczyk . Since this has been open for about a month I'm going to merge this now and prep a release later today. Thanks to all that helped out with this. |
|
Hi all! Since updating to the 0.11.0 version an old issue has come up (mapping.txt being shown as properly uploaded, but then not being shown in AppCenter). I didn't find how to file a bug or request in this project. Where should I head to? |
|
Hi @adriavernetta we haven't moved to GH issues just yet (that's a whole different discussion within the Jenkins community) so at the moment you need to head over to https://issues.jenkins.io/ and create an issue against the appcenter-plugin component. |
|
Thank you @mezpahlan (you tagged the wrong adrian haha). Will open it there :) |
|
Wooops! How many of you are there 😝 . Sorry about that. |
|
Haha, quite a common name in all its forms :) Thanks! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests have been ignored / commented out to save time in getting this out. Some new tests for the new functionality have not been written. I will follow this up later with those tests.I've also not explicitly tested symbol uploading but I am hoping that that has not broken in the recent AppCenter changes.All tests have been added back in and I have tested this with a ~28MB APK file.