Add Java 17 to recommended configurations #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Dec 1, 2022
NotMyFault
approved these changes
Dec 1, 2022
jglick
reviewed
Dec 5, 2022
| @@ -6,5 +6,6 @@ buildPlugin( | |||
| useContainerAgent: true, | |||
| configurations: [ | |||
| [platform: 'linux', jdk: 11], // use 'docker' if you have containerized tests | |||
| [platform: 'windows', jdk: 11] | |||
| [platform: 'windows', jdk: 11], | |||
| [platform: 'linux', jdk: 17] | |||
There was a problem hiding this comment.
For most plugins I would rather recommend just Linux/17 + Windows/11 so we do not waste CI time, under the assumption that it will be rare for there to be a problem which appears on Java 11 but not 17 and appears on Linux but not Windows.
There was a problem hiding this comment.
You can have your preference and I can have mine. I like having the Linux Java 11 configuration present because it is the common case for end users and it is fast, while Windows configurations are slow.
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #546.