Merge pull request #117 from eyalbe4/master

HAP-1151 - Plugin needs concurrent data structure

src/main/java/org/jfrog/hudson/pipeline/common/docker/utils/DockerAgentUtils.java

@@ -13,14 +13,15 @@
 import java.io.IOException;
 import java.io.Serializable;
 import java.util.*;
+import java.util.concurrent.CopyOnWriteArrayList;
 
 /**
  * Created by romang on 8/15/16.
  */
 public class DockerAgentUtils implements Serializable {
     // Docker images cache. Every image which is intersepted by the Build-Info Proxy, is added to this cache,
     // so that it can be used to create the build-info in Artifactory.
-    private static final List<DockerImage> images = Collections.synchronizedList(new ArrayList<DockerImage>());
+    private static final List<DockerImage> images = new CopyOnWriteArrayList<>();
 
     /**
      * Registers an image to be captured by the build-info proxy.

src/main/java/org/jfrog/hudson/pipeline/common/types/buildInfo/BuildInfo.java

@@ -27,6 +27,7 @@
 import java.io.Serializable;
 import java.security.NoSuchAlgorithmException;
 import java.util.*;
+import java.util.concurrent.CopyOnWriteArrayList;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
@@ -40,13 +41,13 @@ public class BuildInfo implements Serializable {
     private String number; // Build number
     private Date startDate;
     private BuildRetention retention;
-    private List<BuildDependency> buildDependencies = Collections.synchronizedList(new ArrayList<>());
-    private List<Artifact> deployedArtifacts = Collections.synchronizedList(new ArrayList<>());
+    private List<BuildDependency> buildDependencies = new CopyOnWriteArrayList<>();
+    private List<Artifact> deployedArtifacts = new CopyOnWriteArrayList<>();
     // The candidates artifacts to be deployed in the 'deployArtifacts' step.
-    private List<DeployDetails> deployableArtifacts = Collections.synchronizedList(new ArrayList<>());
-    private List<Dependency> publishedDependencies = Collections.synchronizedList(new ArrayList<>());
+    private List<DeployDetails> deployableArtifacts = new CopyOnWriteArrayList<>();
+    private List<Dependency> publishedDependencies = new CopyOnWriteArrayList<>();
 
-    private List<Module> modules = Collections.synchronizedList(new ArrayList<>());
+    private List<Module> modules = new CopyOnWriteArrayList<>();
     private Env env = new Env();
     private String agentName;