JENKINS-56109 Table -> Div for freestyle builds #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer distributed anymore https://www.jenkins.io/security/advisory/2018-03-26/#SECURITY-373
|
Did you only fix it for freestyle builds? I see more uses of tabular markup in other jelly files |
|
I fixed it for the global configuration page, there's a big PR for the rest: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make freestyle builds compatible with the upcoming table => div migration,
see:
jenkinsci/jenkins#3895
https://groups.google.com/d/msg/jenkinsci-dev/MpJMqa1Yc9A/Vex1yix8AAAJ
This also removes support for the legacy perforce plugin as it broke the UI when using hpi:run and it's no longer distributed anymore:
jenkins.io/security/advisory/2018-03-26/#SECURITY-373
cc @jsoref