JENKINS-67482 changed from using job name to resolving SCM Head when … #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creating link to workflow branch jobs
mhenschke-atl
commented
Mar 28, 2022
| @@ -117,15 +127,6 @@ public void testCreateMultibranchSource() { | |||
| assertThat(externalLink.getUrlName(), equalTo(BASE_URL + "/projects/PROJ/repos/repo/compare/commits?sourceBranch=refs%2Fheads%2Fbranch2")); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Did a manual test and verified that by using the head directly (which every job upon resolution has), we don't need to differentiate whether or not a pipeline step or checking out from the workflow job SCM. That relationship is no longer necessary, so this test is now covered by testCreateMultibranchSource.
jaguilar-atl
approved these changes
Mar 28, 2022
dkjellin
approved these changes
Mar 30, 2022
src/main/java/com/atlassian/bitbucket/jenkins/internal/provider/SCMHeadByItemProvider.java
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/provider/SCMSourceByItemProvider.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key change here is moving from resolving SCMHead directly instead of using the job name- which happens to, but doesn't need to be the same as the branch name. Resolving the head gives us the git branch name, which is more correct and resolves the double-encoding incidentally.
Providers added for the SCMHead and SCMSource for testing