Implement streaming support from bitbucket. #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkjellin
requested changes
Apr 17, 2023
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketFilePathClient.java
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketFilePathClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketRequestExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/HttpRequestExecutor.java
Outdated
Show resolved
Hide resolved
dkjellin
reviewed
Apr 17, 2023
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketFilePathClient.java
Outdated
Show resolved
Hide resolved
dkjellin
reviewed
Apr 17, 2023
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketFilePathClientImpl.java
Outdated
Show resolved
Hide resolved
|
Fixes JENKINS-66829, I think. |
…NextPageFetcher, BitbucketFilePage objects
…NextPageFetcher, BitbucketFilePage objects
…rsion. Addresses review comments
dkjellin
requested changes
Apr 24, 2023
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketFilePathClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/BitbucketFilePathClientImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/HttpRequestExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/client/HttpRequestExecutor.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/http/HttpRequestExecutorImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/http/HttpRequestExecutorImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/atlassian/bitbucket/jenkins/internal/http/HttpRequestExecutorImpl.java
Outdated
Show resolved
Hide resolved
…version, inline private method
dkjellin
approved these changes
May 8, 2023
| * | ||
| * @param url The URL to hit on bitbucket server end | ||
| * @param additionalConfig additional configuration, such as credentials, that will be used in making calls | ||
| * @param consumer on successful execution, {@link Response} will be passed to consumer |
There was a problem hiding this comment.
consumer is unused, and should be removed I think. It doesn't quite make sense to both return an InputStream AND take in a consumer
mhenschke-atl
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to introduce support for the plugin to retrieve files from bitbucket using the streaming endpoint provided to us. The caller is then presented with an InputStream that they may use.