-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to select aws region to validate. usefull when using govcloud #36
Conversation
really need this |
still really needing this |
Really need this too! 7 Months on. |
i have no influence, and I also would like this in. still waiting some feedback |
I will fix the conflict if the core team said this will be merged, otherwise will keep like this. ping @andresrc |
Hi @cpanato , please solve the conflicts and I'll take care of the review and if everything goes well, merge and release. Sorry for the delay, my availability has been quite low. |
@andresrc thanks for the reply, I've fixed the conflict. |
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the issues, I have added a couple of additional comments.
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
.../resources/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl/credentials.jelly
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small additional comment. Thanks
src/main/java/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl.java
Outdated
Show resolved
Hide resolved
.../resources/com/cloudbees/jenkins/plugins/awscredentials/AWSCredentialsImpl/credentials.jelly
Outdated
Show resolved
Hide resolved
@cpanato @andresrc Unfortunately this still does not address the Region requirement in either of the getCredentials methods. I have created updated code for you to review and include in your PR that I believe will fix the issue with the getCredentials methods: If you would rather, I can create a separate PR to address this, but I believe it is most appropriate to be included in this PR if possible. I have also updated the constructor and credential validation code to support awsRegion properly. |
@dakuhlman Can you merge this PR and create a new one with your updates? I need this functionality. |
Any updates ? I am still recieving error trying to deploy to gov cloud. |
will close this PR, i dont even remember how i did that, and the others I've opened get lost as well :( |
This PR adds a possibility to select the aws region when adding the aws credential.
Useful when adding the govcloud.
before was hardcoded using only us-east-1
fix: #35