Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to select aws region to validate. usefull when using govcloud #36

Closed
wants to merge 10 commits into from
Closed

Add possibility to select aws region to validate. usefull when using govcloud #36

wants to merge 10 commits into from

Conversation

cpanato
Copy link

@cpanato cpanato commented Dec 23, 2017

This PR adds a possibility to select the aws region when adding the aws credential.
Useful when adding the govcloud.

before was hardcoded using only us-east-1

fix: #35

@nowickjo
Copy link

nowickjo commented Jan 9, 2018

really need this

@nowickjo
Copy link

still really needing this

@Dohbedoh
Copy link

Dohbedoh commented Apr 3, 2018

@olivereri
Copy link

Really need this too! 7 Months on.

@cpanato
Copy link
Author

cpanato commented Nov 20, 2018

i have no influence, and I also would like this in. still waiting some feedback

@cpanato
Copy link
Author

cpanato commented Jan 28, 2019

I will fix the conflict if the core team said this will be merged, otherwise will keep like this.

ping @andresrc

@andresrc
Copy link
Contributor

Hi @cpanato , please solve the conflicts and I'll take care of the review and if everything goes well, merge and release. Sorry for the delay, my availability has been quite low.

@cpanato
Copy link
Author

cpanato commented Jan 29, 2019

@andresrc thanks for the reply, I've fixed the conflict.

Copy link
Contributor

@andresrc andresrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the issues, I have added a couple of additional comments.

Copy link
Contributor

@andresrc andresrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small additional comment. Thanks

@dakuhlman
Copy link

dakuhlman commented Apr 23, 2019

@cpanato @andresrc Unfortunately this still does not address the Region requirement in either of the getCredentials methods. I have created updated code for you to review and include in your PR that I believe will fix the issue with the getCredentials methods:
https://gist.github.com/dakuhlman/728812d7e426ac5f5dc3286b2b49bd63

If you would rather, I can create a separate PR to address this, but I believe it is most appropriate to be included in this PR if possible.

I have also updated the constructor and credential validation code to support awsRegion properly.

@ams-tech
Copy link

ams-tech commented May 8, 2019

@dakuhlman Can you merge this PR and create a new one with your updates? I need this functionality.

@skhadka-securus
Copy link

Any updates ? I am still recieving error trying to deploy to gov cloud.

@cpanato
Copy link
Author

cpanato commented Jun 11, 2020

will close this PR, i dont even remember how i did that, and the others I've opened get lost as well :(

@cpanato cpanato closed this Jun 11, 2020
@cpanato cpanato deleted the validate_region_govcloud branch June 11, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use AWS credentials plugin with AWS GovCloud
8 participants