Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace aws-java-sdk with fine-grained plugin #20

Merged
merged 8 commits into from
Oct 4, 2021

Conversation

Vlatombe
Copy link
Member

Downstream PR of

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Vlatombe Vlatombe marked this pull request as draft September 30, 2021 12:59
pom.xml Outdated Show resolved Hide resolved
@Vlatombe Vlatombe marked this pull request as ready for review October 1, 2021 13:55
@Vlatombe
Copy link
Member Author

Vlatombe commented Oct 4, 2021

@jglick could you review this?

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.11.1</version>
<!-- fix upper bound -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for? Something we can address in bom?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enforcer error without it is

Require upper bound dependencies error for joda-time:joda-time:2.8.1 paths to dependency are:
+-io.jenkins.plugins:aws-global-configuration:1.7-SNAPSHOT
  +-org.jenkins-ci.plugins.aws-java-sdk:aws-java-sdk-minimal:1.12.70
    +-com.amazonaws:aws-java-sdk-core:1.12.70
      +-joda-time:joda-time:2.8.1
and
+-io.jenkins.plugins:aws-global-configuration:1.7-SNAPSHOT
  +-io.jenkins.configuration-as-code:test-harness:1.52
    +-com.github.erosb:everit-json-schema:1.13.0
      +-com.damnhandy:handy-uri-templates:2.1.8
        +-joda-time:joda-time:2.10.2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, so I think we need to add at least aws-java-sdk-minimal to the bom.

pom.xml Outdated Show resolved Hide resolved
@jglick jglick merged commit 3d885ea into jenkinsci:master Oct 4, 2021
@Vlatombe Vlatombe deleted the aws-java-sdk-components branch October 5, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants