Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade two dependencies #9

Merged
merged 1 commit into from Dec 6, 2019

Conversation

darinpope
Copy link
Contributor

Downgraded ssh-credentials and aws-java-sdk so the new features from 0.1.0 can be used with CloudBees Core 2.176.4.3

Downgraded ssh-credentials and aws-java-sdk so the new features from 0.1.0 can be used with CloudBees Core 2.176.4.3
@chriskilding
Copy link
Contributor

Tested locally and LGTM

@chriskilding chriskilding merged commit 9835f55 into jenkinsci:master Dec 6, 2019
@darinpope darinpope deleted the downgrade-aws-sdk branch December 6, 2019 20:10
@fimbulvetr
Copy link

This broke the fine-grained IAM policy support, because it downgraded sdk to < 1.11.623. Please see:

https://aws.amazon.com/blogs/opensource/introducing-fine-grained-iam-roles-service-accounts/
https://issues.jenkins-ci.org/browse/JENKINS-60110
https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html

That means this isn't very useful in a K8s Pod.

@chriskilding
Copy link
Contributor

chriskilding commented Dec 10, 2019

@darinpope Would you be able to see about upgrading the necessary bits in the Cloudbees distro so that I can move this plugin back up to the newer version of AWS SDK?

@fimbulvetr As a quick fix in the meantime, you could use a method like:

  • Install the latest plugin version, but after that, specifically upgrade the AWS SDK plugin to a newer version in the Jenkins update center. (Jenkins will use the newest version that is installed.)
  • Or roll back to the v0.1.0 .hpi with your favourite method (manual .hpi download, version pinning in your plugin management script etc)

@chriskilding
Copy link
Contributor

@fimbulvetr I’ve reported the breaking change you’ve seen on JENKINS-60110 to try and bump its priority. Further discussion should go there.

@darinpope
Copy link
Contributor Author

@chriskilding go ahead and bump it to what you need. The 0.1.1 release will still be ok.

@chriskilding
Copy link
Contributor

@fimbulvetr I've now reverted this plugin to use aws-java-sdk 1.11.636 in the release 0.1.2 today. Could you try it out and just confirm that the plugin works once more on EKS?

@fimbulvetr
Copy link

Thanks @chriskilding. I should have the time to check this week. I'll let you know.

@fimbulvetr I've now reverted this plugin to use aws-java-sdk 1.11.636 in the release 0.1.2 today. Could you try it out and just confirm that the plugin works once more on EKS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants