Add disable external url option #97
Conversation
There was a problem hiding this comment.
Looks fine, I assume you can still view the artifacts but they are viewed under a Jenkins URL rather than the user being redirected to an Azure storage URL?
Ideally you would setup a private endpoint so that you don't need to use this and the user can still access it but this should be fine...
...urces/com/microsoft/jenkins/artifactmanager/AzureArtifactConfig/help-disableExternalUrl.html
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/artifactmanager/AzureBlobVirtualFile.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/artifactmanager/AzureBlobVirtualFile.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/artifactmanager/AzureArtifactConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/artifactmanager/AzureArtifactConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/jenkins/artifactmanager/AzureArtifactConfig.java
Outdated
Show resolved
Hide resolved
…actConfig.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…actConfig.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…irtualFile.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…irtualFile.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…actConfig.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…ArtifactConfig/help-disableExternalUrl.html Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
|
If the external URL can be disabled, using a private endpoint would be a good option. |
You don't need to disable the external URL then, if you setup the private endpoint and the DNS resolution, Azure will use its 'magic' DNS so that the public url will resolve a CNAME for the private endpoint and your users will hit the private endpoint NIC and not the public address |
In my special network, it is very difficult to use that magic. |
Fixes #96
Add disable external url option.
One option can disable Jenkins from generating SAS URLs when users want to view artifact files in a closed network.
Testing done