Increase the timeout to prevent timeouts when uploading a large directory #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actConfig.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…actConfig.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…irtualFile.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…irtualFile.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…actConfig.java Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…ArtifactConfig/help-disableExternalUrl.html Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
…s when uploading a large directory (over 10,000 files).
timja
reviewed
Mar 14, 2024
| @@ -245,7 +245,7 @@ public String getUrl() { | |||
| private static class UploadToBlobStorage extends MasterToSlaveFileCallable<Void> { | |||
|
|
|||
| public static final int MAX_QUEUE_SIZE_IN_NETTY = 500; | |||
| public static final int TIMEOUT = 30; | |||
| public static final int TIMEOUT = 600; | |||
There was a problem hiding this comment.
have you confirmed this works in your case? should this be configurable to balance between not hanging jobs and larger uploads?
There was a problem hiding this comment.
yes, it is working good for my usecase.
should this be configurable to balance between not hanging jobs and larger uploads?
how about your opinion?
and I don't think it will hanging jobs because the timeout is still there.
if larger uploads taking too much time, I believe users should consider compressing files into a zip format before uploading them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for fix #95
Increase the timeout from 30 seconds to 10 minutes to prevent timeouts when uploading a large directory (contains over 10,000 files).
Testing done