Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose Vnet and subnet from a different resource group #96

Closed
2 tasks done
sparsick opened this issue Jan 20, 2022 · 0 comments · Fixed by #98
Closed
2 tasks done

Choose Vnet and subnet from a different resource group #96

sparsick opened this issue Jan 20, 2022 · 0 comments · Fixed by #98
Labels
enhancement

Comments

@sparsick
Copy link
Contributor

sparsick commented Jan 20, 2022 •
edited
Loading

What feature do you want to see added?

When using private ip address, you have to specify a vnet and a subnet. Currently, the plugin only support vnet from the same resource group that also the container instance will be used. In some cases, the vnet is set up in a different resource group. Therefore, the name of the resource group should be possible to specify.

This new field could be optional. So the default behaviour is using the same resource group as the container instance will use.

Todo List:

  • Add new optional field Name of resource group
  • Extend the documentation

Upstream changes

No response
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Jan 21, 2022
@sparsick
jenkinsci#96: Extend UI
817f8ba 
- update help text
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Jan 21, 2022
@sparsick
jenkinsci#96: change deployment template to use new resource group fi…
909eee5 
…eld for vnet
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Jan 21, 2022
@sparsick
jenkinsci#96: clean up unused code
59858fd
sparsick added a commit to sparsick/azure-container-agents-plugin that referenced this issue Jan 21, 2022
@sparsick
jenkinsci#96: update doc
63956fb
@sparsick sparsick mentioned this issue Jan 21, 2022
Merged
6 tasks
@timja timja closed this as completed in #98 Jan 24, 2022
@sparsick sparsick mentioned this issue Feb 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Choose Vnet and subnet from a different resource group sparsick/azure-container-agents-plugin
1 participant
@sparsick