JENKINS-64195 Make plugin work on Jenkins >=2.266 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
force-pushed
the
tables-to-divs
branch
from
723da02
to
f1ddda1
Compare
fqueiruga
approved these changes
Nov 16, 2020
|
Hi @xuzhang3 Would you be able to take a look at this please? Without this fix the Azure VM agents plugin UI is broken on versions newer than 2.263. This is because of the tables to divs migration in Jenkins core for a better UI experience: All UI widgets were updated in core, but the azure-commons plugin had forked versions of two components that broke. Please let me know if you have any questions, thanks. Note: This is using a pre-release build of azure-commmons, that one needs to be merged and released first |
oleg-nenashev
approved these changes
Nov 17, 2020
|
LGTM |
|
jenkinsci/azure-commons-plugin#51 Needs to be released first and then updating the version here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires jenkinsci/azure-commons-plugin#51
I've included a couple of other fixes in here, https://issues.jenkins.io/browse/JENKINS-56077 and terminology updates, can be extracted to a different PR if required