-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly find the highest version number for chromedriver #50
Conversation
Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests. |
Does anyone have any thoughts on this? Improvements, suggestions, or does it look good as it is? |
@orrc @daniel-beck @kohsuke Any thoughts? Can this be merged? Would love to hear from anyone. |
Ping @kohsuke |
Correctly find the highest version number for chromedriver
Let's see what happens 😄 |
Looks good in the build log. |
Thanks! |
@daniel-beck Quick question. Does this require a new jenkins release before the change is live? Or can I re-enable the jenkins plugin that uses the chrome-driver binary downloaded by this script right now? |
@Mobrockers No, this is part of the Jenkins project infrastructure. The build I was mentioning provides the metadata to http://updates.jenkins-ci.org/updates/ from which Jenkins downloads it. Between our mirror network being slow to update, and your Jenkins caching this data for a day or so, it may take a while to show up, so in the meantime, enjoy the fixed content at the source: |
@daniel-beck thank you 👏 |
Relates to issue https://issues.jenkins-ci.org/browse/JENKINS-33270
Perhaps there's a better way to get the latest version number, but I am not familiar with groovy, and this seems to work.