Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly find the highest version number for chromedriver #50

Merged
merged 1 commit into from
Mar 22, 2016
Merged

Correctly find the highest version number for chromedriver #50

merged 1 commit into from
Mar 22, 2016

Conversation

rouke-broersma
Copy link

Relates to issue https://issues.jenkins-ci.org/browse/JENKINS-33270

Perhaps there's a better way to get the latest version number, but I am not familiar with groovy, and this seems to work.

@jenkinsadmin
Copy link

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@rouke-broersma
Copy link
Author

Does anyone have any thoughts on this? Improvements, suggestions, or does it look good as it is?

@rouke-broersma
Copy link
Author

@orrc @daniel-beck @kohsuke Any thoughts? Can this be merged? Would love to hear from anyone.

@rouke-broersma
Copy link
Author

Ping @kohsuke

daniel-beck added a commit that referenced this pull request Mar 22, 2016
Correctly find the highest version number for chromedriver
@daniel-beck daniel-beck merged commit 5ca3f6d into jenkins-infra:master Mar 22, 2016
@daniel-beck
Copy link
Contributor

Let's see what happens 😄

@daniel-beck
Copy link
Contributor

Looks good in the build log.

@rouke-broersma
Copy link
Author

Thanks!

@rouke-broersma
Copy link
Author

@daniel-beck Quick question. Does this require a new jenkins release before the change is live? Or can I re-enable the jenkins plugin that uses the chrome-driver binary downloaded by this script right now?

@daniel-beck
Copy link
Contributor

@Mobrockers No, this is part of the Jenkins project infrastructure. The build I was mentioning provides the metadata to http://updates.jenkins-ci.org/updates/ from which Jenkins downloads it.

Between our mirror network being slow to update, and your Jenkins caching this data for a day or so, it may take a while to show up, so in the meantime, enjoy the fixed content at the source:
New: https://ci.jenkins-ci.org/job/infra_backend_crawler/296/artifact/target/org.jenkins-ci.plugins.chromedriver.ChromeDriver.json/*view*/
Old: https://ci.jenkins-ci.org/job/infra_backend_crawler/295/artifact/target/org.jenkins-ci.plugins.chromedriver.ChromeDriver.json/*view*/

@rouke-broersma
Copy link
Author

@daniel-beck thank you 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants