Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-52134: check correct rev class when sending build status #124

Merged
merged 2 commits into from Oct 6, 2018

Conversation

iongchun
Copy link
Contributor

It looks like a confusion of BitbucketSCMSource.MercurialRevision and MercurialSCMSource.MercurialRevision.

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to be safe then sorry 😇

Copy link
Member

@jetersen jetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@jetersen jetersen merged commit 8895766 into jenkinsci:master Oct 6, 2018
@iongchun iongchun deleted the JENKINS-52134 branch October 6, 2018 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants