Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-53179] Extend env variable to facilitate the access to the BO URLs #24

Merged
merged 9 commits into from Jul 19, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 3, 2019

JENKINS-53179

Enable URLs for a page that displays tests and artifacts for a Run.

Depends on jenkinsci/display-url-api-plugin#25

Highlights

  • RUN_ARTIFACTS_DISPLAY_URL points out to the qualified URL for a page that displays artifacts for a Run
  • RUN_TESTS_DISPLAY_URL points out to the qualified URL for a page that displays tests for a Run

UI

node {
    sh 'env | grep -i display_ | sort | tee file.txt'
    archive 'file.txt'
}

image

image

image

@jenkinsci/code-reviewers

pom.xml Outdated
@@ -73,7 +73,7 @@
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>display-url-api</artifactId>
<version>2.3.1</version>
<version>2.3.2-SNAPSHOT</version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Change the version with the incremental one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as jenkinsci/display-url-api-plugin#26 is merged then jenkinsci/display-url-api-plugin#25 will generated an incremental artifact which could be used in this case

@abierbaum
Copy link

@v1v @jglick Was just looking for something exactly like this today. Any chance to get through through and into the plugin?

@StevenGiguere76
Copy link

Anything this patch needs before it can be merged in? Lots of articles pointing to the fact it needs to be solved, has been, but hasn't been pushed fully into the plugin?

@v1v
Copy link
Member Author

v1v commented Feb 13, 2020

Need to address some of the concerns in jenkinsci/display-url-api-plugin#25 in order to move forward

pom.xml Outdated Show resolved Hide resolved
@FallDownT
Copy link

Is anything still needed for this patch to be merged in? This feature would be extremely useful to me right now and it seems ready to merge.

@v1v
Copy link
Member Author

v1v commented Jul 13, 2020

I'm just a contributor, the maintainer is the one to review this PR and merge if happy with

@v1v
Copy link
Member Author

v1v commented Jul 13, 2020

@jenkinsci/code-reviewers this PR has been stalled for a year or so, any feedback?

@olamy
Copy link
Member

olamy commented Jul 14, 2020

@v1v can you please rebase? I would prefer a released version of https://github.com/jenkinsci/display-url-api-plugin but that's my job to do it I guess ;)

@jglick
Copy link
Member

jglick commented Jul 14, 2020

I would prefer a released version of https://github.com/jenkinsci/display-url-api-plugin but that's my job to do it I guess

Certainly this should not be merged while referring to an incremental dependency version. What I have done in the past as a plugin maintainer, or recommended other maintainers do: release the upstream plugin, then use GH suggest changes to guide the downstream PR author to switch to the new release version. At that point downstream is safe to merge & release. (No need for the PR author to rebase; maintainer can always squash-merge if they enjoy destructive history operations.)

@olamy
Copy link
Member

olamy commented Jul 15, 2020

@v1v version 2.3.3 done please update your pull request thanks

pom.xml Outdated Show resolved Hide resolved
@jglick
Copy link
Member

jglick commented Jul 15, 2020

(plus merge conflict resolution)

v1v and others added 2 commits July 19, 2020 19:51
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
@olamy olamy merged commit 126337b into jenkinsci:master Jul 19, 2020
@timja
Copy link
Member

timja commented Jul 31, 2020

@olamy or @jglick could this be released please?

@olamy
Copy link
Member

olamy commented Aug 1, 2020

@timja oh yes I will do it early next week

@syl20bnr
Copy link
Member

@olamy When do you have time to release the version 2.4 of the plugin ?

@olamy
Copy link
Member

olamy commented Aug 25, 2020

@syl20bnr all done buddy
@timja sorry for delay

@syl20bnr
Copy link
Member

Thank you ! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants