JENKINS-45748 Wrong organization URL on PR build notifications #8
Conversation
|
Passing locally here but not on CI :/ |
|
@i386 I think that the failure may be related to a null org or something similar. I had this code for this problem but didn't have time to test it well https://github.com/alvarolobato/blueocean-display-url-plugin/tree/JENKINS-45748 I'll have a look at what is failing on your PR. |
|
Nevermind it seems to have been something related to git and the CI it is working for me locally too. |
|
@i386 I've been testing this and there seems to be something wrong. I've created a PR and the link goes to: instead of
Notice the Let me find where this is happening. |
| } | ||
|
|
||
| private String getJobURL(BlueOrganization organization, Job<?, ?> job) { | ||
| String jobPath = job.getParent() instanceof MultiBranchProject ? job.getParent().getFullName() : job.getFullName(); |
There was a problem hiding this comment.
So this is where I think the problem is. Instead of getFullName it should be using:
Functions.getRelativeNameFrom(item, group);
where group is the org.getGroup
Like here:
|
|
||
| return getRoot() + "organizations/jenkins/" + jobPath + "/"; | ||
| private String getJobURL(BlueOrganization organization, MultiBranchProject<?, ?> project) { | ||
| return String.format("%sorganizations/%s/%s/", getRoot(), Util.rawEncode(organization.getName()), Util.rawEncode(project.getFullName())); |
Please review @alvarolobato @imeredith @amuniz