Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker Hub/Registry Notification to the managed set #2439

Closed
basil opened this issue Aug 29, 2023 · 1 comment · Fixed by #2595
Closed

Add Docker Hub/Registry Notification to the managed set #2439

basil opened this issue Aug 29, 2023 · 1 comment · Fixed by #2595
Assignees
Labels
enhancement New feature or request

Comments

@basil
Copy link
Member

basil commented Aug 29, 2023

What feature do you want to see added?

This plugin has 1,886 installations. It is important to the Jenkins community and important to CloudBees, so it should be in this repository's test matrix.

Upstream changes

No response

@basil basil added the enhancement New feature or request label Aug 29, 2023
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Sep 19, 2023
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Sep 19, 2023
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Sep 30, 2023
@MarkEWaite
Copy link
Contributor

MarkEWaite added a commit to MarkEWaite/dockerhub-notification-plugin that referenced this issue Oct 21, 2023
DockerImageExtractor.getDockerImagesUsedByJobFromAll expects a non-null
job argument but the test environment on the master branch and on the
test branch were both passing a null job.  When the docker-workflow
plugin is included in the test dependencies, then an implementation of
the abstract method is used that expects the NonNull to be honored.

It seems like this should have been detected by spotbugs, since the
argument is annotated NonNull in the called method and is being passed
a null value from this method.

jenkinsci/bom#2439 is the issue that detected
this implementation problem.
MarkEWaite added a commit to MarkEWaite/dockerhub-notification-plugin that referenced this issue Oct 21, 2023
DockerImageExtractor.getDockerImagesUsedByJobFromAll expects a non-null
job argument but the test environment on the master branch and on the
test branch were both passing a null job.  When the docker-workflow
plugin is included in the test dependencies, then an implementation of
the abstract method is used that expects the NonNull to be honored.

It seems like this should have been detected by spotbugs, since the
argument is annotated NonNull in the called method and is being passed
a null value from this method.

jenkinsci/bom#2439 is the issue that detected
this implementation problem.
MarkEWaite added a commit to MarkEWaite/dockerhub-notification-plugin that referenced this issue Oct 21, 2023
DockerImageExtractor.getDockerImagesUsedByJobFromAll expects a non-null
job argument but the test environment on the master branch and on the
test branch were both passing a null job.  When the docker-workflow
plugin is included in the test dependencies, then an implementation of
the abstract method is used that expects the NonNull to be honored.

It seems like this should have been detected by spotbugs, since the
argument is annotated NonNull in the called method and is being passed
a null value from this method.

jenkinsci/bom#2439 is the issue that detected
this implementation problem.
MarkEWaite added a commit to MarkEWaite/bom that referenced this issue Oct 21, 2023
Fixes jenkinsci#2439

Test latest incremental build
@MarkEWaite MarkEWaite self-assigned this Oct 21, 2023
@MarkEWaite MarkEWaite linked a pull request Oct 23, 2023 that will close this issue
5 tasks
MarkEWaite added a commit that referenced this issue Oct 28, 2023
Fixes #2439

Test latest incremental build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants