Add docker-workflow plugin to the managed set
#2464
Conversation
MarkEWaite
added
the
full-test
| @@ -429,6 +429,11 @@ | |||
| <artifactId>docker-java-api</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>docker-workflow</artifactId> | |||
There was a problem hiding this comment.
Could then remove docker-commons.
There was a problem hiding this comment.
Thanks. I have removed docker-commons and confirmed that sample plugin tests pass locally. That has been pushed as commit f0bb487
Since docker-workflow depends on several other plugins, should I remove those other dependencies from the sample plugin as well?
docker-workflow Dependencies
- Pipeline: Basic Steps ≥ 1017.vb_45b_302f0cea_
- Pipeline: Groovy ≥ 3659.v582dc37621d8
- Pipeline: Nodes and Processes ≥ 1246.v5524618ea_097
- Pipeline: Step API ≥ 639.v6eca_cd8c04a_a_
- Folders ≥ 6.758.vfd75d09eea_a_1
- Docker Commons ≥ 419.v8e3cd84ef49c
- Pipeline: Declarative ≥ 2.2131.vb_9788088fdb_5
I was able to remove the following plugins from the sample-plugin pom file and still pass mvn verify:
Is it OK to remove those five dependencies from the sample plugin?
There was a problem hiding this comment.
Thanks. If this run fails, I'll add those changes to the next run. If it succeeds and merges, I'll submit them as a separate pull request.
There was a problem hiding this comment.
#2470 is the pull request that removes several transitive dependencies from the pom of the sample plugin.
README advises that the dependencies in the sample plugin should be maintained as we would any other plugin, with the top level dependencies declared and the transitive dependencies calculated by Maven. Since docker-workflow depends on docker-commons, we don't need to declare docker-commons in the sample plugin.
Add
docker-workflowplugin to the managed setTesting done
Confirmed that
PLUGINS=docker-workflow bash local-test.shpasses on a Debian machine with Java 21+34 (early access release).Rely on ci.jenkins.io and the
full-testlabel to confirm other tests are passing.Fixes
Submitter checklist