Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert checks-api from 2.0.1 to 2.0.0 #2512

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Revert checks-api from 2.0.1 to 2.0.0 #2512

merged 2 commits into from
Sep 17, 2023

Commits on Sep 16, 2023

  1. Pin previous credentials-binding release for LTS profiles 

    The most recent release of the credentials-binding plugin adds masking
for base64 credentials.  That's a nice improvement.  Unfortunately,
it causes one of the config-file-provider tests to fail.

Adapt older bom profiles to "Bump credentials-binding (jenkinsci#2509)" by
retaining the current version of the credentials binding plugin on
the weekly release and pinning the previous credentials binding plugin
release on the LTS releases.

Could exclude the test failure on all releases, but it seemed better
to be able to detect test failures from the weekly release even if we
can't yet test the new version with the LTS releases.

This partially reverts commit bab8257.
    @MarkEWaite
    MarkEWaite committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    1e18003 View commit details
    Browse the repository at this point in the history

  2. Revert "Bump checks-api.version from 2.0.0 to 2.0.1 in /bom-weekly (j… 

    …enkinsci#2471)"

jenkinsci#2484 describes the unexpected
addition of commons-text-api as a new dependency for many consumers of
the plugin bill of materials.

Rather than having more and more plugins adding dependencies on the
commons-text-api or the commons-lang3-api plugin, let's keep the
checks-api dependency at 2.0.0 instead of 2.0.1.

jenkinsci/checks-api-plugin#233 is the issue
reported to the checks-api plugin.  Once that issue is resolved, we
should be able to use more recent checks-api plugin versions.

Dependency updates that had to add commons-text-api included:

* jenkinsci/bitbucket-kubernetes-credentials-plugin#133
* jenkinsci/elastic-axis-plugin#309
* jenkinsci/nodelabelparameter-plugin#265
* jenkinsci/testng-plugin-plugin#244

This reverts commit 729dfb2.
    @MarkEWaite
    MarkEWaite committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    25a3381 View commit details
    Browse the repository at this point in the history